Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Trying to fix test broken on Mac Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1639 matching lines...) Expand 10 before | Expand all | Expand 10 after
1650 ax_tree_snapshot_callbacks_.erase(it); 1650 ax_tree_snapshot_callbacks_.erase(it);
1651 } else { 1651 } else {
1652 NOTREACHED() << "Received AX tree snapshot response for unknown id"; 1652 NOTREACHED() << "Received AX tree snapshot response for unknown id";
1653 } 1653 }
1654 } 1654 }
1655 1655
1656 void RenderFrameHostImpl::OnToggleFullscreen(bool enter_fullscreen) { 1656 void RenderFrameHostImpl::OnToggleFullscreen(bool enter_fullscreen) {
1657 if (enter_fullscreen) 1657 if (enter_fullscreen)
1658 delegate_->EnterFullscreenMode(GetLastCommittedURL().GetOrigin()); 1658 delegate_->EnterFullscreenMode(GetLastCommittedURL().GetOrigin());
1659 else 1659 else
1660 delegate_->ExitFullscreenMode(); 1660 delegate_->ExitFullscreenMode(true);
scheib 2016/01/04 22:26:48 /* will_cause_resize */ true
bokan 2016/01/05 15:37:11 Done.
1661 1661
1662 // The previous call might change the fullscreen state. We need to make sure 1662 // The previous call might change the fullscreen state. We need to make sure
1663 // the renderer is aware of that, which is done via the resize message. 1663 // the renderer is aware of that, which is done via the resize message.
1664 render_view_host_->GetWidget()->WasResized(); 1664 render_view_host_->GetWidget()->WasResized();
1665 } 1665 }
1666 1666
1667 void RenderFrameHostImpl::OnDidStartLoading(bool to_different_document) { 1667 void RenderFrameHostImpl::OnDidStartLoading(bool to_different_document) {
1668 // Any main frame load to a new document should reset the load since it will 1668 // Any main frame load to a new document should reset the load since it will
1669 // replace the current page and any frames. 1669 // replace the current page and any frames.
1670 if (to_different_document && !GetParent()) 1670 if (to_different_document && !GetParent())
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
2500 *dst = src; 2500 *dst = src;
2501 2501
2502 if (src.routing_id != -1) 2502 if (src.routing_id != -1)
2503 dst->tree_id = RoutingIDToAXTreeID(src.routing_id); 2503 dst->tree_id = RoutingIDToAXTreeID(src.routing_id);
2504 2504
2505 if (src.parent_routing_id != -1) 2505 if (src.parent_routing_id != -1)
2506 dst->parent_tree_id = RoutingIDToAXTreeID(src.parent_routing_id); 2506 dst->parent_tree_id = RoutingIDToAXTreeID(src.parent_routing_id);
2507 } 2507 }
2508 2508
2509 } // namespace content 2509 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698