Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1488563003: PPC: [turbofan] Implemented the optional Float32RoundUp operator. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch02
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Implemented the optional Float32RoundUp operator. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/78026a4b1d797cc61d5f8dbef1a6ee45d553e859 Cr-Commit-Position: refs/heads/master@{#32423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1485653003 Patch 1

Dependent Patchsets:

Issue 1487863002 Patch 1

Messages

Total messages: 8 (2 generated)
MTBrandyberry
5 years ago (2015-11-30 20:58:20 UTC) #1
michael_dawson
On 2015/11/30 20:58:20, mtbrandyberry wrote: lgtm
5 years ago (2015-11-30 21:26:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488563003/1
5 years ago (2015-11-30 22:13:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 22:34:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78026a4b1d797cc61d5f8dbef1a6ee45d553e859 Cr-Commit-Position: refs/heads/master@{#32423}
5 years ago (2015-11-30 22:35:10 UTC) #7
john.yan
5 years ago (2015-11-30 22:48:42 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698