Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1487863002: PPC: [interpreter] Switch passing of new.target to register. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch03
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [interpreter] Switch passing of new.target to register. Port 3d004eeab23c8b47bd9bdd2cc66434dcc19a1b2f Original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. The interpreter entry trampoline stores this value in a bytecode register so that it can be accessed directly by the interpreter. The size of the interpreter stack frame hence grows by one slot. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4544 LOG=n Committed: https://crrev.com/81b4015ebf2dae892f6ce74a54046653c69313e6 Cr-Commit-Position: refs/heads/master@{#32425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
MTBrandyberry
5 years ago (2015-11-30 20:58:43 UTC) #1
michael_dawson
On 2015/11/30 20:58:43, mtbrandyberry wrote: lgtm
5 years ago (2015-11-30 21:27:05 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1488563003 Patch 1). Please resolve the dependency and ...
5 years ago (2015-11-30 21:28:08 UTC) #5
Michael Starzinger
LGTM.
5 years ago (2015-11-30 22:08:28 UTC) #6
john.yan
lgtm
5 years ago (2015-11-30 22:49:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487863002/1
5 years ago (2015-11-30 23:09:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 23:32:09 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-30 23:32:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81b4015ebf2dae892f6ce74a54046653c69313e6
Cr-Commit-Position: refs/heads/master@{#32425}

Powered by Google App Engine
This is Rietveld 408576698