Port cronet_package GYP target to GN

components/cronet/tools/extract_from_jars.py

Index: components/cronet/tools/extract_from_jars.py
diff --git a/components/cronet/tools/extract_from_jars.py b/components/cronet/tools/extract_from_jars.py
index d72d46c162b1f2bce77cbb7a478e6b3f7e919d34..c148664ad371a114be773e5cccd109845bd19072 100755
--- a/components/cronet/tools/extract_from_jars.py
+++ b/components/cronet/tools/extract_from_jars.py
@@ -31,6 +31,7 @@ def ExtractJars(options):
 
 def main():
   parser = optparse.OptionParser()
+  build_utils.AddDepfileOption(parser)
   parser.add_option('--classes-dir', help='Directory to extract .class files.')
   parser.add_option('--jars', help='Paths to jars to extract.')
   parser.add_option('--stamp', help='Path to touch on success.')
@@ -39,6 +40,13 @@ def main():
 
   ExtractJars(options)
 
+  if options.depfile:
+    input_paths = []
+    for root, _, filenames in os.walk(options.classes_dir):

[brettw, 2015/12/21 20:25:02]

It looks like this is writing the names of the extracted files to the dep file.
This is backwards, the dep file lists the inputs. I think doing this will cause
some confusion. Just write the python dependencies to this file so things will
get redone when the scripts change.

+      input_paths.extend(os.path.join(root, f) for f in filenames)
+    build_utils.WriteDepfile(options.depfile,
+                             input_paths + build_utils.GetPythonDependencies())
+
   if options.stamp:
     build_utils.Touch(options.stamp)