Port cronet_package GYP target to GN

components/cronet/tools/extract_from_jars.py

 #!/usr/bin/env python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import fnmatch
 import optparse
 import os
 import sys
@@ skipping 13 matching lines @@
   build_utils.DeleteDirectory(jar_cwd)
   build_utils.MakeDirectory(jar_cwd)
   for jar in build_utils.ParseGypList(options.jars):
     jar_path = os.path.abspath(jar)
     jar_cmd = ['jar', 'xf', jar_path]
     build_utils.CheckOutput(jar_cmd, cwd=jar_cwd)
 
 
 def main():
   parser = optparse.OptionParser()
+  build_utils.AddDepfileOption(parser)
   parser.add_option('--classes-dir', help='Directory to extract .class files.')
   parser.add_option('--jars', help='Paths to jars to extract.')
   parser.add_option('--stamp', help='Path to touch on success.')
 
   options, _ = parser.parse_args()
 
   ExtractJars(options)
 
+  if options.depfile:
+    input_paths = []
+    for root, _, filenames in os.walk(options.classes_dir):

[brettw, 2015/12/21 20:25:02]

It looks like this is writing the names of the extracted files to the dep file.
This is backwards, the dep file lists the inputs. I think doing this will cause
some confusion. Just write the python dependencies to this file so things will
get redone when the scripts change.

+      input_paths.extend(os.path.join(root, f) for f in filenames)
+    build_utils.WriteDepfile(options.depfile,
+                             input_paths + build_utils.GetPythonDependencies())
+
   if options.stamp:
     build_utils.Touch(options.stamp)
 
 
 if __name__ == '__main__':
   sys.exit(main())