Issue 148823002: *** DO NOT LAND *** Measure the size and complexity of the old multicol implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148823002: * DO NOT LAND * Measure the size and complexity of the old multicol implementation. (Closed)

Created:
6 years, 10 months ago by mstensho (USE GERRIT)

Modified:
6 years, 9 months ago

Reviewers:

CC:
blink-reviews, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, zoltan1, dsinclair, sof, eae+blinkwatch, leviw+renderwatch, fs, blink-layers+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, jchaffraix+rendering, pdr, bemjb+rendering_chromium.org, Stephen Chennney, rwlbuis, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

*** DO NOT LAND *** Measure the size and complexity of the old multicol implementation. This patch removes the old ColumnInfo-based multicol implementation, just to measure how many lines of code it comprises, and how intruding it is in central layout code. The region based multicol implementation is kept and still works. BUG=

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -1890 lines)			Patch
M	Source/core/dom/Document.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/core/rendering/ColumnInfo.h	View	1 chunk	+0 lines, -122 lines	0 comments	Download
M	Source/core/rendering/LayoutState.h	View	5 chunks	+2 lines, -12 lines	0 comments	Download
M	Source/core/rendering/LayoutState.cpp	View	8 chunks	+4 lines, -68 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.h	View	10 chunks	+0 lines, -45 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	34 chunks	+24 lines, -1087 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.cpp	View	11 chunks	+11 lines, -72 lines	0 comments	Download
M	Source/core/rendering/RenderBox.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderBox.cpp	View	4 chunks	+3 lines, -32 lines	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.cpp	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderGeometryMap.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderInline.cpp	View	4 chunks	+2 lines, -18 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View	5 chunks	+1 line, -13 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	13 chunks	+4 lines, -302 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	5 chunks	+0 lines, -16 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	5 chunks	+4 lines, -17 lines	0 comments	Download
M	Source/core/rendering/RenderText.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/rendering/RenderView.h	View	4 chunks	+7 lines, -12 lines	0 comments	Download
M	Source/core/rendering/RenderView.cpp	View	6 chunks	+3 lines, -46 lines	0 comments	Download
M	Source/core/rendering/TextAutosizer.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGText.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Issue 148823002: *** DO NOT LAND *** Measure the size and complexity of the old multicol implementation. (Closed)

Description

Patch Set 1 #

Issue 148823002: * DO NOT LAND * Measure the size and complexity of the old multicol implementation. (Closed)