Use FixedTypedArrayBase's body descriptor for static visiting

Use FixedTypedArrayBase's body descriptor for static visiting

BUG=none
R=ishell@chromium.org,hpayer@chromium.org
LOG=n

Committed: https://crrev.com/2ce0e87fb2432a16818be32767788d8f71dd3870
Cr-Commit-Position: refs/heads/master@{#32618}

[Igor Sheludko, 2015-12-01 13:53:01]

lgtm with a nit:

https://codereview.chromium.org/1488053002/diff/1/src/objects-body-descriptor...
File src/objects-body-descriptors-inl.h (right):

https://codereview.chromium.org/1488053002/diff/1/src/objects-body-descriptor...
src/objects-body-descriptors-inl.h:105: StaticVisitor::VisitPointers(
Why did you change this?

[jochen (gone - plz use gerrit), 2015-12-01 14:00:57]

https://codereview.chromium.org/1488053002/diff/1/src/objects-body-descriptor...
File src/objects-body-descriptors-inl.h (right):

https://codereview.chromium.org/1488053002/diff/1/src/objects-body-descriptor...
src/objects-body-descriptors-inl.h:105: StaticVisitor::VisitPointers(
On 2015/12/01 at 13:53:00, Igor Sheludko wrote:
> Why did you change this?

because the StaticScavengingVisitor doesn't implement VisitPointer - so I could
either implement it there, or map both IteratePointer and IteratePointers to the
same method

[Igor Sheludko, 2015-12-01 14:09:09]

https://codereview.chromium.org/1488053002/diff/1/src/objects-body-descriptor...
File src/objects-body-descriptors-inl.h (right):

https://codereview.chromium.org/1488053002/diff/1/src/objects-body-descriptor...
src/objects-body-descriptors-inl.h:105: StaticVisitor::VisitPointers(
On 2015/12/01 14:00:57, jochen wrote:
> On 2015/12/01 at 13:53:00, Igor Sheludko wrote:
> > Why did you change this?
> 
> because the StaticScavengingVisitor doesn't implement VisitPointer - so I
could
> either implement it there, or map both IteratePointer and IteratePointers to
the
> same method

I think it is better to modify signature of the
StaticScavengeVisitor::VisitPointer() instead in order to be uniform with all
other static visitors.

[jochen (gone - plz use gerrit), 2015-12-01 15:17:10]

done

[Igor Sheludko, 2015-12-01 15:22:45]

https://codereview.chromium.org/1488053002/diff/20001/src/heap/scavenger-inl.h
File src/heap/scavenger-inl.h (right):

https://codereview.chromium.org/1488053002/diff/20001/src/heap/scavenger-inl....
src/heap/scavenger-inl.h:41: void StaticScavengeVisitor::VisitPointer(Heap*
heap, Object** p) {
What about removing this old one? Given that all these functions must be inlined
anyway the extra |obj| parameter should be optimized away by the compiler.

[jochen (gone - plz use gerrit), 2015-12-01 15:29:28]

https://codereview.chromium.org/1488053002/diff/20001/src/heap/scavenger-inl.h
File src/heap/scavenger-inl.h (right):

https://codereview.chromium.org/1488053002/diff/20001/src/heap/scavenger-inl....
src/heap/scavenger-inl.h:41: void StaticScavengeVisitor::VisitPointer(Heap*
heap, Object** p) {
On 2015/12/01 at 15:22:45, Igor Sheludko wrote:
> What about removing this old one? Given that all these functions must be
inlined anyway the extra |obj| parameter should be optimized away by the
compiler.

not sure what you mean?

[jochen (gone - plz use gerrit), 2015-12-01 16:11:00]

ptal

[Igor Sheludko, 2015-12-01 16:28:22]

lgtm from my side.

[jochen (gone - plz use gerrit), 2015-12-04 12:56:42]

that's technically no longer needed, but makes fixed typed arrays less of a
snowflake, wdyt?

[payer, 2015-12-04 13:29:32]

hpayer@google.com changed reviewers:
+ hpayer@google.com

[payer, 2015-12-04 13:29:32]

lgtm

[Hannes Payer (out of office), 2015-12-04 13:31:53]

lgtm

[jochen (gone - plz use gerrit), 2015-12-04 14:18:33]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-12-04 14:18:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488053002/40001

[commit-bot: I haz the power, 2015-12-04 14:42:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-04 14:43:18]

Description was changed from

==========
Use FixedTypedArrayBase's body descriptor for static visiting

BUG=none
R=ishell@chromium.org,hpayer@chromium.org
LOG=n
==========

to

==========
Use FixedTypedArrayBase's body descriptor for static visiting

BUG=none
R=ishell@chromium.org,hpayer@chromium.org
LOG=n

Committed: https://crrev.com/2ce0e87fb2432a16818be32767788d8f71dd3870
Cr-Commit-Position: refs/heads/master@{#32618}
==========

[commit-bot: I haz the power, 2015-12-04 14:43:19]

Patchset 3 (id:??) landed as
https://crrev.com/2ce0e87fb2432a16818be32767788d8f71dd3870
Cr-Commit-Position: refs/heads/master@{#32618}