Chromium Code Reviews| Index: media/audio/audio_device_thread.h |
| diff --git a/media/audio/audio_device_thread.h b/media/audio/audio_device_thread.h |
| index 1f63c21d9f96329e71b4d79d92622934464b16ee..f90e54b1df30bd73339366f809d1e23a239ed675 100644 |
| --- a/media/audio/audio_device_thread.h |
| +++ b/media/audio/audio_device_thread.h |
| @@ -50,8 +50,8 @@ class MEDIA_EXPORT AudioDeviceThread { |
| // before Process can be called. |
| virtual void MapSharedMemory() = 0; |
| - // Called whenever we receive notifications about pending data. |
| - virtual void Process(uint32 pending_data) = 0; |
| + // Called whenever we receive notifications about pending input data. |
| + virtual void Process(uint32_t pending_data) = 0; |
| protected: |
| // Protected so that derived classes can access directly. |
| @@ -75,7 +75,12 @@ class MEDIA_EXPORT AudioDeviceThread { |
| // Starts the audio thread. The thread must not already be running. If |
| // |sychronized_buffers| is set, the browser expects to be notified via the |
| - // |socket| every time AudioDeviceThread::Process() completes. |
| + // |socket| every time AudioDeviceThread::Process() completes. |input| should |
|
tommi (sloooow) - chröme
2015/12/08 08:34:51
what does |input| refer to?
Henrik Grunell
2015/12/08 09:30:34
Whether this object is used for input audio or not
tommi (sloooow) - chröme
2015/12/08 10:08:09
It looks like this refers to a variable that can b
Henrik Grunell
2015/12/08 11:12:32
Merge error. removed.
|
| + // be true for input and false for output. It is used for reading the right |
| + // amount of data from the socket. |
| + // TODO(grunell): |input| is ugly, but there are plans to re-use a thread for |
| + // multiple inputs/outputs (see todo comment above) so we do it this way |
| + // meanwhile instead of using separate classes. |
| void Start(AudioDeviceThread::Callback* callback, |
| base::SyncSocket::Handle socket, |
| const char* thread_name, |