Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1487913002: [Offline pages] Fixing crashes caused by access to offline pages marked for deletion (Closed)

Created:
5 years ago by fgorski
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing crashes caused by access to offline pages marked for deletion This patch fixes the problems caused by: * HasOfflinePages * GetPageByBookmarkId * GetPageByOfflineURL * GetPageByOnlineURL All of which allow for access to the offline page that is marked for deletion, which means there is no valid bookmark corresponding to them. This leads to crashes in the bookmark UI, as well as exposing functionality that should not work. BUG=560424 Review URL: https://codereview.chromium.org/1475883003 Cr-Commit-Position: refs/heads/master@{#361746} (cherry picked from commit 1a6c2e1840f8b64c242ddb680b7de34ba27520c6) Committed: https://chromium.googlesource.com/chromium/src/+/130d38be1228e105829ea624d616a9aaa9e9ecb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M components/offline_pages/offline_page_model.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M components/offline_pages/offline_page_model_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fgorski
5 years ago (2015-11-30 22:56:57 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
130d38be1228e105829ea624d616a9aaa9e9ecb2.

Powered by Google App Engine
This is Rietveld 408576698