[Offline pages] Fixing crashes caused by access to offline pages marked for deletion

[Offline pages] Fixing crashes caused by access to offline pages marked for deletion

This patch fixes the problems caused by:
* HasOfflinePages
* GetPageByBookmarkId
* GetPageByOfflineURL
* GetPageByOnlineURL
All of which allow for access to the offline page that is marked for
deletion, which means there is no valid bookmark corresponding to them.
This leads to crashes in the bookmark UI, as well as exposing
functionality that should not work.

BUG=560424
Committed: https://crrev.com/1a6c2e1840f8b64c242ddb680b7de34ba27520c6
Cr-Commit-Position: refs/heads/master@{#361746}

[fgorski, 2015-11-25 18:50:55]

fgorski@chromium.org changed reviewers:
+ courage@chromium.org

[fgorski, 2015-11-25 18:50:56]

PTAL

[Michael Courage, 2015-11-25 19:00:58]

lgtm

https://codereview.chromium.org/1475883003/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1475883003/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:258: for (const auto& iter :
offline_pages_) {
optional nit: seems like there's a pretty even split between "iter" and
"id_page_pair" in this file, but the other nearby instances of "for (iterator :
offline_pages_)" go with the latter, which seems a little bit clearer to me.

[fgorski, 2015-11-25 19:27:26]

addressed

https://codereview.chromium.org/1475883003/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1475883003/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:258: for (const auto& iter :
offline_pages_) {
On 2015/11/25 19:00:58, Michael Courage wrote:
> optional nit: seems like there's a pretty even split between "iter" and
> "id_page_pair" in this file, but the other nearby instances of "for (iterator
:
> offline_pages_)" go with the latter, which seems a little bit clearer to me.

Done.

[fgorski, 2015-11-25 20:56:25]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-11-25 20:56:25]

The patchset sent to the CQ was uploaded after l-g-t-m from courage@chromium.org
Link to the patchset: https://codereview.chromium.org/1475883003/#ps20001
(title: "Addressing CR feedback")

[commit-bot: I haz the power, 2015-11-25 20:58:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475883003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475883003/20001

[commit-bot: I haz the power, 2015-11-25 22:10:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 22:12:17]

Description was changed from

==========
[Offline pages] Fixing crashes caused by access to offline pages marked for
deletion

This patch fixes the problems caused by:
* HasOfflinePages
* GetPageByBookmarkId
* GetPageByOfflineURL
* GetPageByOnlineURL
All of which allow for access to the offline page that is marked for
deletion, which means there is no valid bookmark corresponding to them.
This leads to crashes in the bookmark UI, as well as exposing
functionality that should not work.

BUG=560424
==========

to

==========
[Offline pages] Fixing crashes caused by access to offline pages marked for
deletion

This patch fixes the problems caused by:
* HasOfflinePages
* GetPageByBookmarkId
* GetPageByOfflineURL
* GetPageByOnlineURL
All of which allow for access to the offline page that is marked for
deletion, which means there is no valid bookmark corresponding to them.
This leads to crashes in the bookmark UI, as well as exposing
functionality that should not work.

BUG=560424

Committed: https://crrev.com/1a6c2e1840f8b64c242ddb680b7de34ba27520c6
Cr-Commit-Position: refs/heads/master@{#361746}
==========

[commit-bot: I haz the power, 2015-11-25 22:12:18]

Patchset 2 (id:??) landed as
https://crrev.com/1a6c2e1840f8b64c242ddb680b7de34ba27520c6
Cr-Commit-Position: refs/heads/master@{#361746}