Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chromeos/network/network_state.cc

Issue 14876021: Re-factor network_event_log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address final nits Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_handler_callbacks.cc ('k') | chromeos/network/network_state_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state.cc
diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc
index 7092c2170bc4e818ef24decbd9cc8ab50edd877b..3c24999ac30b2fac48e309446b7dd49035670bde 100644
--- a/chromeos/network/network_state.cc
+++ b/chromeos/network/network_state.cc
@@ -16,8 +16,6 @@
namespace {
-const char kLogModule[] = "NetworkState";
-
bool ConvertListValueToStringVector(const base::ListValue& string_list,
std::vector<std::string>* result) {
for (size_t i = 0; i < string_list.GetSize(); ++i) {
@@ -196,9 +194,8 @@ void NetworkState::UpdateName() {
std::string valid_ssid = ValidateUTF8(name());
if (valid_ssid != name()) {
set_name(valid_ssid);
- network_event_log::AddEntry(
- kLogModule, "UpdateName",
- base::StringPrintf("%s: UTF8: %s", path().c_str(), name().c_str()));
+ NET_LOG_DEBUG("UpdateName", base::StringPrintf(
+ "%s: UTF8: %s", path().c_str(), name().c_str()));
}
return;
}
@@ -210,7 +207,7 @@ void NetworkState::UpdateName() {
} else {
std::string desc = base::StringPrintf("%s: Error processing: %s",
path().c_str(), hex_ssid_.c_str());
- network_event_log::AddEntry(kLogModule, "UpdateName", desc);
+ NET_LOG_DEBUG("UpdateName", desc);
LOG(ERROR) << desc;
ssid = name();
}
@@ -218,9 +215,8 @@ void NetworkState::UpdateName() {
if (IsStringUTF8(ssid)) {
if (ssid != name()) {
set_name(ssid);
- network_event_log::AddEntry(
- kLogModule, "UpdateName",
- base::StringPrintf("%s: UTF8: %s", path().c_str(), name().c_str()));
+ NET_LOG_DEBUG("UpdateName", base::StringPrintf(
+ "%s: UTF8: %s", path().c_str(), name().c_str()));
}
return;
}
@@ -236,10 +232,9 @@ void NetworkState::UpdateName() {
std::string utf8_ssid;
if (base::ConvertToUtf8AndNormalize(ssid, encoding, &utf8_ssid)) {
set_name(utf8_ssid);
- network_event_log::AddEntry(
- kLogModule, "UpdateName",
- base::StringPrintf("%s: Encoding=%s: %s", path().c_str(),
- encoding.c_str(), name().c_str()));
+ NET_LOG_DEBUG("UpdateName", base::StringPrintf(
+ "%s: Encoding=%s: %s", path().c_str(),
+ encoding.c_str(), name().c_str()));
return;
}
}
@@ -247,10 +242,9 @@ void NetworkState::UpdateName() {
// Unrecognized encoding. Only use raw bytes if name_ is empty.
if (name().empty())
set_name(ssid);
- network_event_log::AddEntry(
- kLogModule, "UpdateName",
- base::StringPrintf("%s: Unrecognized Encoding=%s: %s", path().c_str(),
- encoding.c_str(), name().c_str()));
+ NET_LOG_DEBUG("UpdateName", base::StringPrintf(
+ "%s: Unrecognized Encoding=%s: %s", path().c_str(),
+ encoding.c_str(), name().c_str()));
}
// static
« no previous file with comments | « chromeos/network/network_handler_callbacks.cc ('k') | chromeos/network/network_state_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698