Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chromeos/network/network_handler_callbacks.cc

Issue 14876021: Re-factor network_event_log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address final nits Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_handler_callbacks.h ('k') | chromeos/network/network_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_handler_callbacks.cc
diff --git a/chromeos/network/network_handler_callbacks.cc b/chromeos/network/network_handler_callbacks.cc
index f10a12f1d825b342d1664b6679d4185ca2a4b8a4..597b8bd9f71d4f944f6706260980e7b974eb8ce4 100644
--- a/chromeos/network/network_handler_callbacks.cc
+++ b/chromeos/network/network_handler_callbacks.cc
@@ -11,8 +11,6 @@
namespace chromeos {
namespace network_handler {
-const char kLogModule[] = "ShillError";
-
// These are names of fields in the error data dictionary for ErrorCallback.
const char kErrorName[] = "errorName";
const char kErrorMessage[] = "errorMessage";
@@ -29,17 +27,16 @@ base::DictionaryValue* CreateErrorData(const std::string& service_path,
return error_data;
}
-void ShillErrorCallbackFunction(const std::string& module,
- const std::string& path,
+void ShillErrorCallbackFunction(const std::string& path,
const ErrorCallback& error_callback,
const std::string& error_name,
const std::string& error_message) {
- std::string error = "Shill Error in " + module;
+ std::string error = "Shill Error";
if (!path.empty())
error += " For " + path;
- error += ": " + error_name + " : " + error_message;
- LOG(ERROR) << error;
- network_event_log::AddEntry(kLogModule, module, error);
+ error += ": " + error_name;
+ NET_LOG_ERROR(error, error_message);
+ LOG(ERROR) << error << " : " << error_message;
if (error_callback.is_null())
return;
scoped_ptr<base::DictionaryValue> error_data(
« no previous file with comments | « chromeos/network/network_handler_callbacks.h ('k') | chromeos/network/network_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698