Adding AGC stats in combination with report of missing input audio on Mac

Adding AGC stats in combination with report of missing input audio on Mac

BUG=549021
Committed: https://crrev.com/2957f907c8e24205a9faffb4a14ae63e491f44aa
Cr-Commit-Position: refs/heads/master@{#366967}

[henrika (OOO until Aug 14), 2015-12-02 15:11:16]

Description was changed from

==========
Adding AGC stats in combination with report of missing input audio on Mac

BUG=
==========

to

==========
Adding AGC stats in combination with report of missing input audio on Mac

BUG=549021
==========

[henrika (OOO until Aug 14), 2015-12-02 15:11:16]

henrika@chromium.org changed reviewers:
+ tommi@chromium.org

[henrika (OOO until Aug 14), 2015-12-02 15:14:04]

Heads-up Tommi, plan to land this CL (with XML as well) once our current CHECK
experiment is done. I want to see if failing cases have AGC on or off. This API
covers the analog AGC, hence the volume control will be modified periodically
when enabled. Could in theory cause issues.

[tommi (sloooow) - chröme, 2015-12-02 15:28:30]

rs lgtm

[henrika (OOO until Aug 14), 2015-12-02 15:39:50]

henrika@chromium.org changed reviewers:
+ asvitkine@chromium.org

[henrika (OOO until Aug 14), 2015-12-02 15:39:51]

Adding asvitkine for XML part.

[Alexei Svitkine (slow), 2015-12-03 18:51:07]

lgtm % nit

https://codereview.chromium.org/1487393003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1487393003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:17901: +<histogram
name="Media.Audio.AutomaticGainControlMac" enum="BooleanSuccess">
Nit: BooleanEnabled

[henrika (OOO until Aug 14), 2015-12-28 10:13:16]

Thanks. Done.

https://codereview.chromium.org/1487393003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1487393003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:17901: +<histogram
name="Media.Audio.AutomaticGainControlMac" enum="BooleanSuccess">
On 2015/12/03 18:51:07, asvitkine (OOO Dec24 - Jan4) wrote:
> Nit: BooleanEnabled

Done.

[henrika (OOO until Aug 14), 2015-12-28 10:13:42]

The CQ bit was checked by henrika@chromium.org

[henrika (OOO until Aug 14), 2015-12-28 10:13:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1487393003/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2015-12-28 10:13:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487393003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487393003/60001

[commit-bot: I haz the power, 2015-12-28 11:26:40]

Description was changed from

==========
Adding AGC stats in combination with report of missing input audio on Mac

BUG=549021
==========

to

==========
Adding AGC stats in combination with report of missing input audio on Mac

BUG=549021
==========

[commit-bot: I haz the power, 2015-12-28 11:26:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-28 11:27:47]

Description was changed from

==========
Adding AGC stats in combination with report of missing input audio on Mac

BUG=549021
==========

to

==========
Adding AGC stats in combination with report of missing input audio on Mac

BUG=549021

Committed: https://crrev.com/2957f907c8e24205a9faffb4a14ae63e491f44aa
Cr-Commit-Position: refs/heads/master@{#366967}
==========

[commit-bot: I haz the power, 2015-12-28 11:27:47]

Patchset 4 (id:??) landed as
https://crrev.com/2957f907c8e24205a9faffb4a14ae63e491f44aa
Cr-Commit-Position: refs/heads/master@{#366967}