Issue 148733005: Move failing ASSERT on ARM to a more sane place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148733005: Move failing ASSERT on ARM to a more sane place. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest

Modified:
6 years, 10 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Move failing ASSERT on ARM to a more sane place. Objects can actually be stored into themselves. This fails when no write barrier is needed (eg, the object was just allocated). R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19095

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/mjsunit/recursive-store-opt.js	View	2 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

6 years, 10 months ago (2014-02-05 10:12:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19095 (presubmit successful).