Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 148733005: Move failing ASSERT on ARM to a more sane place. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4068 matching lines...) Expand 10 before | Expand all | Expand 10 after
4079 temp, 4079 temp,
4080 GetLinkRegisterState(), 4080 GetLinkRegisterState(),
4081 kSaveFPRegs, 4081 kSaveFPRegs,
4082 OMIT_REMEMBERED_SET, 4082 OMIT_REMEMBERED_SET,
4083 OMIT_SMI_CHECK); 4083 OMIT_SMI_CHECK);
4084 } 4084 }
4085 } 4085 }
4086 4086
4087 // Do the store. 4087 // Do the store.
4088 Register value = ToRegister(instr->value()); 4088 Register value = ToRegister(instr->value());
4089 ASSERT(!object.is(value));
4090 SmiCheck check_needed = 4089 SmiCheck check_needed =
4091 instr->hydrogen()->value()->IsHeapObject() 4090 instr->hydrogen()->value()->IsHeapObject()
4092 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 4091 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
4093 if (access.IsInobject()) { 4092 if (access.IsInobject()) {
4094 MemOperand operand = FieldMemOperand(object, offset); 4093 MemOperand operand = FieldMemOperand(object, offset);
4095 __ Store(value, operand, representation); 4094 __ Store(value, operand, representation);
4096 if (instr->hydrogen()->NeedsWriteBarrier()) { 4095 if (instr->hydrogen()->NeedsWriteBarrier()) {
4097 // Update the write barrier for the object for in-object properties. 4096 // Update the write barrier for the object for in-object properties.
4098 __ RecordWriteField(object, 4097 __ RecordWriteField(object,
4099 offset, 4098 offset,
(...skipping 1640 matching lines...) Expand 10 before | Expand all | Expand 10 after
5740 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5739 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5741 __ ldr(result, FieldMemOperand(scratch, 5740 __ ldr(result, FieldMemOperand(scratch,
5742 FixedArray::kHeaderSize - kPointerSize)); 5741 FixedArray::kHeaderSize - kPointerSize));
5743 __ bind(&done); 5742 __ bind(&done);
5744 } 5743 }
5745 5744
5746 5745
5747 #undef __ 5746 #undef __
5748 5747
5749 } } // namespace v8::internal 5748 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698