Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.h

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move strings to resources and properly enable the settings link. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.h
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.h b/chrome/browser/ui/webui/signin/login_ui_service.h
index d15efe7d2bc4b5a36166c796ae96e8f8aa01cf23..c32cf28b63acb7faf3f76ada6f8037e5d7024c3b 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.h
+++ b/chrome/browser/ui/webui/signin/login_ui_service.h
@@ -31,6 +31,17 @@ class LoginUIService : public KeyedService {
virtual ~LoginUI() {}
};
+ // Used when the sync confirmation UI is closed to signify which option was
+ // selected by the user.
+ enum SyncConfirmationUIClosedResults {
+ // Start sync immediately.
+ SYNC_WITH_DEFAULT_SETTINGS,
+ // Show the user the sync settings before starting sync.
+ CONFIGURE_SYNC_FIRST,
+ // The signing process was aborted, don't start sync or show settings.
+ ABORT_SIGNIN,
+ };
+
// Interface for obervers of LoginUIService.
class Observer {
public:
@@ -42,10 +53,10 @@ class LoginUIService : public KeyedService {
// |ui| The login UI that was just closed; will never be null.
virtual void OnLoginUIClosed(LoginUI* ui) {}
- // Called when the sync confirmation UI is closed. |configure_sync_first|
- // is true if the user has requested to configure the sync settings before
- // sync starts.
- virtual void OnSyncConfirmationUIClosed(bool configure_sync_first) {}
+ // Called when the sync confirmation UI is closed. |results| indicates the
+ // option chosen by the user in the confirmation UI.
+ virtual void OnSyncConfirmationUIClosed(
+ SyncConfirmationUIClosedResults results) {}
// Called when a confirmation UI for untrusted signin is shown.
virtual void OnUntrustedLoginUIShown() {}
@@ -75,7 +86,7 @@ class LoginUIService : public KeyedService {
void LoginUIClosed(LoginUI* ui);
// Called when the sync settings confirmation UI is closed.
- void SyncConfirmationUIClosed(bool configure_sync_first);
+ void SyncConfirmationUIClosed(SyncConfirmationUIClosedResults results);
// Called when a confirmation UI for untrusted signin is shown.
void UntrustedLoginUIShown();

Powered by Google App Engine
This is Rietveld 408576698