Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move strings to resources and properly enable the settings link. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/signin_view_controller.cc
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller.cc b/chrome/browser/ui/views/profiles/signin_view_controller.cc
index d5fd524c046bb92c98711587bfdaa4e0d65474a5..7e8e0ea07bb41d334e500dd00bca6ebea4fa1911 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller.cc
+++ b/chrome/browser/ui/views/profiles/signin_view_controller.cc
@@ -120,6 +120,15 @@ views::WebView* SigninViewController::CreateGaiaWebView(
return web_view;
}
+views::WebView* SigninViewController::CreateSyncConfirmationWebView(
+ Profile* profile) {
+ views::WebView* web_view = new views::WebView(profile);
+ web_view->LoadInitialURL(GURL("chrome://sync-confirmation"));
Roger Tawa OOO till Jul 10th 2015/12/03 20:33:45 Use kChromeUISyncConfirmationURL.
anthonyvd 2015/12/03 21:48:03 Done.
+ web_view->SetPreferredSize(gfx::Size(450, 360));
+
+ return web_view;
+}
+
void SigninViewController::ShowModalSignin(
profiles::BubbleViewMode mode, Browser* browser) {
CloseModalSignin();
@@ -139,6 +148,12 @@ void SigninViewController::ResetModalSigninDelegate() {
modal_signin_delegate_ = nullptr;
}
+void SigninViewController::ShowModalSyncConfirmationDialog(Browser* browser) {
+ CloseModalSignin();
+ modal_signin_delegate_ = new ModalSigninDelegate(
+ this, CreateSyncConfirmationWebView(browser->profile()), browser);
+}
+
// static
bool SigninViewController::ShouldShowModalSigninForMode(
profiles::BubbleViewMode mode) {

Powered by Google App Engine
This is Rietveld 408576698