chrome/browser/ui/views/profiles/profile_chooser_view.cc - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.html ('K') | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/profiles/signin_view_controller.h » ('j') | chrome/browser/ui/webui/signin/sync_confirmation_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

index 2c21f4703bb1a2c47ab3f9e7fd6a757e3208438b..f4b159c75f10e004baf89cc59ce59ac7d785c068 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

@@ -861,7 +861,7 @@ void ProfileChooserView::WindowClosing() {

if (tutorial_mode_ == profiles::TUTORIAL_MODE_CONFIRM_SIGNIN) {

LoginUIServiceFactory::GetForProfile(browser_->profile())->

- SyncConfirmationUIClosed(false /* configure_sync_first */);

+ SyncConfirmationUIClosed(LoginUIService::SYNC_WITH_DEFAULT_SETTINGS);

}

@@ -909,7 +909,7 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,

ShowViewFromMode(profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH);

} else if (sender == tutorial_sync_settings_ok_button_) {

LoginUIServiceFactory::GetForProfile(browser_->profile())->

- SyncConfirmationUIClosed(false /* configure_sync_first */);

+ SyncConfirmationUIClosed(LoginUIService::SYNC_WITH_DEFAULT_SETTINGS);

DismissTutorial();

ProfileMetrics::LogProfileNewAvatarMenuSignin(

ProfileMetrics::PROFILE_AVATAR_MENU_SIGNIN_OK);

@@ -1010,7 +1010,7 @@ void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {

PostActionPerformed(ProfileMetrics::PROFILE_DESKTOP_MENU_ADD_ACCT);

} else if (sender == tutorial_sync_settings_link_) {

LoginUIServiceFactory::GetForProfile(browser_->profile())->

- SyncConfirmationUIClosed(true /* configure_sync_first */);

+ SyncConfirmationUIClosed(LoginUIService::CONFIGURE_SYNC_FIRST);

tutorial_mode_ = profiles::TUTORIAL_MODE_NONE;

ProfileMetrics::LogProfileNewAvatarMenuSignin(

ProfileMetrics::PROFILE_AVATAR_MENU_SIGNIN_SETTINGS);