chrome/browser/resources/sync_confirmation/sync_confirmation.html - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Unified Diff: chrome/browser/resources/sync_confirmation/sync_confirmation.html

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.css ('K') | « chrome/browser/resources/sync_confirmation/sync_confirmation.css ('k') | chrome/browser/resources/sync_confirmation/sync_confirmation.js » ('j') | chrome/browser/ui/webui/signin/sync_confirmation_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/sync_confirmation/sync_confirmation.html

diff --git a/chrome/browser/resources/sync_confirmation/sync_confirmation.html b/chrome/browser/resources/sync_confirmation/sync_confirmation.html

new file mode 100644

index 0000000000000000000000000000000000000000..4d17363b63c47a39b4a896c65a868f8534ca1d31

--- /dev/null

+++ b/chrome/browser/resources/sync_confirmation/sync_confirmation.html

@@ -0,0 +1,36 @@

+<!doctype html>

+<html>

Dan Beam 2016/01/21 03:57:33 this should probably be <html i18n-values="dir:te

anthonyvd 2016/01/21 22:36:11 Done.

+ <head>

+ <meta charset="utf-8">

Dan Beam 2016/01/21 03:57:33 why do you need this?

anthonyvd 2016/01/21 22:36:11 It was pointed to me that it was required for inte

Dan Beam 2016/01/22 01:26:57 it seems that lang does affect this[1], but it's n

anthonyvd 2016/01/22 17:19:56 Sounds good, thanks!

+ <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

+ <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">

+ <link rel="stylesheet" href="sync-confirmation.css"></link>

Dan Beam 2016/01/21 03:57:33 - should be _

anthonyvd 2016/01/21 22:36:11 Done.

+ <script src="chrome://resources/js/cr.js"></script>

+ <script src="chrome://resources/js/load_time_data.js"></script>

+ <script src="chrome://resources/js/util.js"></script>

+ <script src="sync-confirmation.js"></script>

Dan Beam 2016/01/21 03:57:33 why do these need to be in the head? they will blo

Dan Beam 2016/01/21 03:57:33 - should be _

anthonyvd 2016/01/21 22:36:11 Done.

+ </head>

+ <body>

+ <div class="container">

+ <div class="top-title-bar" i18n-content="syncConfirmationTitle"></div>

+ <div class="details">

+ <div class="picture-container">

+ <div class="picture">

+ <img id="profile-picture"></img>

+ <div class="checkmark-bubble"></div>

+ </div>

+ <div class="sync-message"

+ i18n-values=".innerHTML:syncConfirmationBody"></div>

+ <div class="action-container">

+ <paper-button id="confirmButton"

+ i18n-content="syncConfirmationConfirmLabel"></paper-button>

+ <paper-button id="undoButton"

+ i18n-content="syncConfirmationUndoLabel"></paper-button>

+ </div>

+ </body>

+ <script src="chrome://sync-confirmation/strings.js"></script>

+ <script src="chrome://resources/js/i18n_template.js"></script>

+</html>