chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use Polymer where relevant. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/sync_confirmation/sync_confirmation.js ('k') | chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h

diff --git a/chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h b/chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h

index c8cac37215f21ee5321de2df789339de71fd3b5a..719c24459badfcec9b434b489a0125b47483e55f 100644

--- a/chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h

+++ b/chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h

@@ -32,7 +32,7 @@ class CustodianProfileDownloaderService : public KeyedService,

// ProfileDownloaderDelegate:

bool NeedsProfilePicture() const override;

- int GetDesiredImageSideLength() const override;

+ unsigned int GetDesiredImageSideLength() const override;

Marc Treib 2016/01/11 09:23:05 Using "unsigned" to mean "this will never be negat

anthonyvd 2016/01/11 17:05:35 I took this to be a case where the value we're ret

Marc Treib 2016/01/11 17:27:28 Aaand now you don't need my LGTM anymore ;)

std::string GetCachedPictureURL() const override;

Profile* GetBrowserProfile() override;

bool IsPreSignin() const override;