Implement the new Sync Confirmation dialog on Linux and Windows.

chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SUPERVISED_USER_LEGACY_CUSTODIAN_PROFILE_DOWNLOADER_SERVICE_H_
 #define CHROME_BROWSER_SUPERVISED_USER_LEGACY_CUSTODIAN_PROFILE_DOWNLOADER_SERVICE_H_
 
 #include "base/callback.h"
 #include "chrome/browser/profiles/profile_downloader.h"
 #include "chrome/browser/profiles/profile_downloader_delegate.h"
@@ skipping 14 matching lines @@
 
   // Downloads the GAIA account information for the |custodian_profile_|.
   // This is a best-effort attempt with no error reporting nor timeout.
   // If the download is successful, the profile's full (display) name will
   // be returned via the callback. If the download fails or never completes,
   // the callback will not be called.
   void DownloadProfile(const DownloadProfileCallback& callback);
 
   // ProfileDownloaderDelegate:
   bool NeedsProfilePicture() const override;
-  int GetDesiredImageSideLength() const override;
+  unsigned int GetDesiredImageSideLength() const override;

[Marc Treib, 2016/01/11 09:23:05]

Using "unsigned" to mean "this will never be negative" is disallowed by the
style guide: https://google.github.io/styleguide/cppguide.html#Integer_Types

[anthonyvd, 2016/01/11 17:05:35]

I took this to be a case where the value we're returning is semantically
unsigned (a size is conceptually >= 0). However, looking at the code in views::,
it seems you're right and sizes are all represented as signed integers.

Reverted this part of the change, thanks!

[Marc Treib, 2016/01/11 17:27:28]

Aaand now you don't need my LGTM anymore ;)

   std::string GetCachedPictureURL() const override;
   Profile* GetBrowserProfile() override;
   bool IsPreSignin() const override;
   void OnProfileDownloadSuccess(ProfileDownloader* downloader) override;
   void OnProfileDownloadFailure(
       ProfileDownloader* downloader,
       ProfileDownloaderDelegate::FailureReason reason) override;
 
  private:
   friend class CustodianProfileDownloaderServiceFactory;
   // Use |CustodianProfileDownloaderServiceFactory::GetForProfile(...)| to
   // get instances of this service.
   explicit CustodianProfileDownloaderService(Profile* custodian_profile);
 
   scoped_ptr<ProfileDownloader> profile_downloader_;
   DownloadProfileCallback download_callback_;
 
   // Owns us via the KeyedService mechanism.
   Profile* custodian_profile_;
 
   std::string last_downloaded_profile_email_;
   std::string in_progress_profile_email_;
 };
 
 #endif  // CHROME_BROWSER_SUPERVISED_USER_LEGACY_CUSTODIAN_PROFILE_DOWNLOADER_SERVICE_H_