chrome/browser/profiles/profile_downloader_unittest.cc - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_downloader_unittest.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use Polymer where relevant. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_downloader_delegate.h ('k') | chrome/browser/resources/sync_confirmation/sync_confirmation.css » ('j') | chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_downloader_unittest.cc

diff --git a/chrome/browser/profiles/profile_downloader_unittest.cc b/chrome/browser/profiles/profile_downloader_unittest.cc

index 185916415ea782dba5b78a38fb07b80eb25b2d34..850310f81cfd12e5a756a758234892c32d33ddfb 100644

--- a/chrome/browser/profiles/profile_downloader_unittest.cc

+++ b/chrome/browser/profiles/profile_downloader_unittest.cc

@@ -62,7 +62,7 @@ class ProfileDownloaderTest : public testing::Test,

}

bool NeedsProfilePicture() const override { return true; };

- int GetDesiredImageSideLength() const override { return 128; };

+ unsigned int GetDesiredImageSideLength() const override { return 128; };

std::string GetCachedPictureURL() const override { return ""; };

Profile* GetBrowserProfile() override { return profile_.get(); };

bool IsPreSignin() const override { return false; }