Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1487213002: Special-case top-level final JS fields. (Closed)

Created:
5 years ago by ochafik
Modified:
5 years ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Special-case top-level final JS fields to make them non-lazy (follow-up to John's suggestion in https://codereview.chromium.org/1486473002/) BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ae540463805b2e9d49743e2d9bfd39ee5ffa99f5

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -58 lines) Patch
M lib/runtime/dart/_isolate_helper.js View 2 chunks +5 lines, -9 lines 0 comments Download
M lib/runtime/dart/_js_mirrors.js View 4 chunks +10 lines, -16 lines 0 comments Download
M lib/runtime/dart/js.js View 4 chunks +6 lines, -12 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 4 chunks +19 lines, -7 lines 0 comments Download
M tool/input_sdk/private/utils.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ochafik
5 years ago (2015-12-02 00:55:57 UTC) #3
Jennifer Messerly
DOH! I looked at this and forgot to LGTM. Sorry about that! LGTM*2
5 years ago (2015-12-08 21:01:56 UTC) #4
ochafik
5 years ago (2015-12-09 15:10:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ae540463805b2e9d49743e2d9bfd39ee5ffa99f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698