Special-case top-level final JS fields.

tool/input_sdk/private/utils.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart._utils;
 
 import 'dart:_foreign_helper' show JS;
 
 /// This library defines a set of general javascript utilities for us
 /// by the Dart runtime.
 // TODO(ochafik): Rewrite some of these in Dart when possible.
 
-// TODO(ochafik): Make these final + special-case them in js_codegen to fix
-// Analyzer errors.
-const defineProperty = JS('', 'Object.defineProperty');
-const getOwnPropertyDescriptor = JS('', 'Object.getOwnPropertyDescriptor');
-const getOwnPropertyNames = JS('', 'Object.getOwnPropertyNames');
-const getOwnPropertySymbols = JS('', 'Object.getOwnPropertySymbols');
+final defineProperty = JS('', 'Object.defineProperty');
+final getOwnPropertyDescriptor = JS('', 'Object.getOwnPropertyDescriptor');
+final getOwnPropertyNames = JS('', 'Object.getOwnPropertyNames');
+final getOwnPropertySymbols = JS('', 'Object.getOwnPropertySymbols');
 
-const hasOwnProperty = JS('', 'Object.prototype.hasOwnProperty');
+final hasOwnProperty = JS('', 'Object.prototype.hasOwnProperty');
 
 // TODO(ochafik): Add ES6 class syntax support to JS intrinsics to avoid this.
-const StrongModeError = JS('', '''(function() {
+final StrongModeError = JS('', '''(function() {
   function StrongModeError(message) {
     Error.call(this);
     this.message = message;
   };
   Object.setPrototypeOf(StrongModeError.prototype, Error.prototype);
   return StrongModeError;
 })()''');
 
 /// This error indicates a strong mode specific failure.
 void throwStrongModeError(String message) => JS('', '''((message) => {
@@ skipping 85 matching lines @@
 export_(to, from, show, hide) => JS('', '''((to, from, show, hide) => {
   if (show == void 0 || show.length == 0) {
     show = getOwnNamesAndSymbols(from);
   }
   if (hide != void 0) {
     var hideMap = new Set(hide);
     show = show.filter((k) => !hideMap.has(k));
   }
   return copyTheseProperties(to, from, show);
 })(#, #, #, #)''', to, from, show, hide);