runtime/vm/flow_graph_builder.cc - Issue 14872002: Improve load forwarding:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 14872002: Improve load forwarding: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index b4b833ad9bd9c7a97ad7bfd6a73fe396d64403c2..ef6b1614a0a44ef6fb83350882f91202a519228b 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -2634,6 +2634,7 @@ void EffectGraphVisitor::VisitLoadInstanceFieldNode(

for_instance.value(),

node->field().Offset(),

AbstractType::ZoneHandle(node->field().type()));

+ load->set_field(&Field::ZoneHandle(node->field().raw()));

srdjan 2013/05/02 21:00:54 That works, but I wonder why you do not reuse the

Vyacheslav Egorov (Google) 2013/05/02 21:20:25 Cleaned this up. set_field was requiring non-const

ReturnDefinition(load);

}