runtime/vm/flow_graph_optimizer.h - Issue 14872002: Improve load forwarding:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 14872002: Improve load forwarding: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_optimizer.h

diff --git a/runtime/vm/flow_graph_optimizer.h b/runtime/vm/flow_graph_optimizer.h

index 8a616a344dc441ed3d032b71b1d5b50f6850fa25..5e37bdbaea4211ee5574d3a4b767615f825f673f 100644

--- a/runtime/vm/flow_graph_optimizer.h

+++ b/runtime/vm/flow_graph_optimizer.h

@@ -35,7 +35,7 @@ class FlowGraphOptimizer : public FlowGraphVisitor {

// shift can be a truncating Smi shift-left and result is always Smi.

void TryOptimizeLeftShiftWithBitAndPattern();

- void Canonicalize();

+ bool Canonicalize();

srdjan 2013/05/02 21:00:54 Please add comment when is true/false returned.

Vyacheslav Egorov (Google) 2013/05/02 21:20:25 Done.

void EliminateDeadPhis();