Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1487083003: It's not just the last column set that may need additional fragmentainer groups. (Closed)

Created:
5 years ago by mstensho (USE GERRIT)
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

It's not just the last column set that may need additional fragmentainer groups. appendNewFragmentainerGroupIfNeeded() assumed that we were always dealing with the last column set, but we need to use the column set that contains the specified flow thread block offset. Moved hasFragmentainerGroupForColumnAt() from LayoutMultiColumnFlowThread to LayoutMultiColumnSet and simplified the code somewhat. BUG=447718 R=leviw@chromium.org Committed: https://crrev.com/4b28fbfc464953fecd282f2fc5a6cb0e27f4517e Cr-Commit-Position: refs/heads/master@{#362604}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sqrt(squareheight) #

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
The test has beer in it!
5 years ago (2015-12-01 21:05:07 UTC) #1
leviw_travelin_and_unemployed
BEER IS SERVED. LGTM. https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp (right): https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp#newcode449 third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:449: // Its height height is ...
5 years ago (2015-12-01 22:11:20 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp (right): https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp#newcode449 third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:449: // Its height height is indefinite for now. On ...
5 years ago (2015-12-01 23:00:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487083003/20001
5 years ago (2015-12-01 23:04:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 02:48:49 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-02 02:50:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b28fbfc464953fecd282f2fc5a6cb0e27f4517e
Cr-Commit-Position: refs/heads/master@{#362604}

Powered by Google App Engine
This is Rietveld 408576698