It's not just the last column set that may need additional fragmentainer groups.

It's not just the last column set that may need additional fragmentainer groups.

appendNewFragmentainerGroupIfNeeded() assumed that we were always dealing with
the last column set, but we need to use the column set that contains the
specified flow thread block offset. Moved hasFragmentainerGroupForColumnAt()
from LayoutMultiColumnFlowThread to LayoutMultiColumnSet and simplified the
code somewhat.

BUG=447718
R=leviw@chromium.org

Committed: https://crrev.com/4b28fbfc464953fecd282f2fc5a6cb0e27f4517e
Cr-Commit-Position: refs/heads/master@{#362604}

[mstensho (USE GERRIT), 2015-12-01 21:05:07]

The test has beer in it!

[leviw_travelin_and_unemployed, 2015-12-01 22:11:20]

BEER IS SERVED.

LGTM.

https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
(right):

https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:449: //
Its height height is indefinite for now.
Let's fix this comment while we're here. I suspect only one of its heights is
unknown at this point ;)

[mstensho (USE GERRIT), 2015-12-01 23:00:29]

https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
(right):

https://codereview.chromium.org/1487083003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:449: //
Its height height is indefinite for now.
On 2015/12/01 22:11:20, leviw wrote:
> Let's fix this comment while we're here. I suspect only one of its heights is
> unknown at this point ;)

Done.

[mstensho (USE GERRIT), 2015-12-01 23:00:34]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2015-12-01 23:00:34]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1487083003/#ps20001
(title: "sqrt(squareheight)")

[commit-bot: I haz the power, 2015-12-01 23:04:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487083003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487083003/20001

[commit-bot: I haz the power, 2015-12-02 02:48:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 02:50:11]

Description was changed from

==========
It's not just the last column set that may need additional fragmentainer groups.

appendNewFragmentainerGroupIfNeeded() assumed that we were always dealing with
the last column set, but we need to use the column set that contains the
specified flow thread block offset. Moved hasFragmentainerGroupForColumnAt()
from LayoutMultiColumnFlowThread to LayoutMultiColumnSet and simplified the
code somewhat.

BUG=447718
R=leviw@chromium.org
==========

to

==========
It's not just the last column set that may need additional fragmentainer groups.

appendNewFragmentainerGroupIfNeeded() assumed that we were always dealing with
the last column set, but we need to use the column set that contains the
specified flow thread block offset. Moved hasFragmentainerGroupForColumnAt()
from LayoutMultiColumnFlowThread to LayoutMultiColumnSet and simplified the
code somewhat.

BUG=447718
R=leviw@chromium.org

Committed: https://crrev.com/4b28fbfc464953fecd282f2fc5a6cb0e27f4517e
Cr-Commit-Position: refs/heads/master@{#362604}
==========

[commit-bot: I haz the power, 2015-12-02 02:50:12]

Patchset 2 (id:??) landed as
https://crrev.com/4b28fbfc464953fecd282f2fc5a6cb0e27f4517e
Cr-Commit-Position: refs/heads/master@{#362604}