third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h - Issue 1487083003: It's not just the last column set that may need additional fragmentainer groups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 1487083003: It's not just the last column set that may need additional fragmentainer groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sqrt(squareheight) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

index f65d1b68a3c34f7d33c1c081a335eed827589211..ccd7cdadc7d986fcec830f0f2af1066ba2abf8be 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

@@ -96,6 +96,9 @@ public:

LayoutMultiColumnSet* nextSiblingMultiColumnSet() const;

LayoutMultiColumnSet* previousSiblingMultiColumnSet() const;

+ // Return true if we have a fragmentainer group that can hold a column at the specified flow thread block offset.

+ bool hasFragmentainerGroupForColumnAt(LayoutUnit offsetInFlowThread) const;

MultiColumnFragmentainerGroup& appendNewFragmentainerGroup();

LayoutUnit logicalTopInFlowThread() const;