Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1487033002: Revert of Fix Android framework build (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
bsalomon, tomhudson
CC:
reviews_skia.org, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix Android framework build (patchset #1 id:1 of https://codereview.chromium.org/1491563003/ ) Reason for revert: eeebdb538d476c1bfc8b63a946094ca1b505ecd1 was reverted, so this one needs to be reverted, too Original issue's description: > Fix Android framework build > > eeebdb538d476c1bfc8b63a946094ca1b505ecd1 did not update a Config that > only builds if SK_BUILD_FOR_ANDROID_FRAMEWORK. This appears to be the > necessary parameter that is missing. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/cb6cb21cd9d27054810d2c80ef534dcddd615d4b TBR=bsalomon@google.com,tomhudson@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/9323dc6a72de301f23e1187adc2365395b4b23d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scroggo
Created Revert of Fix Android framework build
5 years ago (2015-12-01 16:08:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487033002/1
5 years ago (2015-12-01 16:08:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9323dc6a72de301f23e1187adc2365395b4b23d8
5 years ago (2015-12-01 16:08:21 UTC) #4
tomhudson
5 years ago (2015-12-01 16:15:07 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698