content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc - Issue 1486873002: Mac: Require child AllocateGpuMemoryBuffer to not fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

Issue 1486873002: Mac: Require child AllocateGpuMemoryBuffer to not fail (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GPU proc as well Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/child_io_surface_manager_mac.h ('K') | « content/child/child_io_surface_manager_mac.cc ('k') | content/common/gpu/gpu_memory_buffer_factory_io_surface.cc » ('j') | content/common/gpu/gpu_memory_buffer_factory_io_surface.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc b/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

index 9794bbfa47dedff6ba239452bb39143554ecfac5..d7fc2a492d75bc93f4e221e7f66d88e2b1a05a0f 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

@@ -55,8 +55,7 @@ GpuMemoryBufferImplIOSurface::CreateFromHandle(

const DestructionCallback& callback) {

base::ScopedCFTypeRef<IOSurfaceRef> io_surface(

gfx::IOSurfaceManager::GetInstance()->AcquireIOSurface(handle.id));

- if (!io_surface)

- return nullptr;

+ CHECK(io_surface);

reveman 2015/12/01 20:49:04 I think this needs to be able to fail without cras

return make_scoped_ptr(

new GpuMemoryBufferImplIOSurface(handle.id, size, format, callback,