Mac: Require child AllocateGpuMemoryBuffer to not fail

content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h"
 
 #include "base/logging.h"
 #include "content/common/gpu/gpu_memory_buffer_factory_io_surface.h"
 #include "ui/gfx/buffer_format_util.h"
 #include "ui/gfx/mac/io_surface_manager.h"
@@ skipping 37 matching lines @@
 // static
 scoped_ptr<GpuMemoryBufferImplIOSurface>
 GpuMemoryBufferImplIOSurface::CreateFromHandle(
     const gfx::GpuMemoryBufferHandle& handle,
     const gfx::Size& size,
     gfx::BufferFormat format,
     gfx::BufferUsage usage,
     const DestructionCallback& callback) {
   base::ScopedCFTypeRef<IOSurfaceRef> io_surface(
       gfx::IOSurfaceManager::GetInstance()->AcquireIOSurface(handle.id));
-  if (!io_surface)
-    return nullptr;
+  CHECK(io_surface);

[reveman, 2015/12/01 20:49:04]

I think this needs to be able to fail without crashing as this client interface
is also used in the browser process and potentially for importing buffers that
are not guaranteed to be valid. Can we move this CHECK up to some renderer side
code that should never fail?

 
   return make_scoped_ptr(
       new GpuMemoryBufferImplIOSurface(handle.id, size, format, callback,
                                        io_surface.release(), LockFlags(usage)));
 }
 
 // static
 bool GpuMemoryBufferImplIOSurface::IsConfigurationSupported(
     gfx::BufferFormat format,
     gfx::BufferUsage usage) {
@@ skipping 45 matching lines @@
 }
 
 gfx::GpuMemoryBufferHandle GpuMemoryBufferImplIOSurface::GetHandle() const {
   gfx::GpuMemoryBufferHandle handle;
   handle.type = gfx::IO_SURFACE_BUFFER;
   handle.id = id_;
   return handle;
 }
 
 }  // namespace content