Mac: Require child AllocateGpuMemoryBuffer to not fail

content/child/child_gpu_memory_buffer_manager.cc

Index: content/child/child_gpu_memory_buffer_manager.cc
diff --git a/content/child/child_gpu_memory_buffer_manager.cc b/content/child/child_gpu_memory_buffer_manager.cc
index c83ceea64155878cb1e3e3ae0de17bff2c53f002..2c25b3e7c6ed43bf38ff9bd9f19214ba0421f04f 100644
--- a/content/child/child_gpu_memory_buffer_manager.cc
+++ b/content/child/child_gpu_memory_buffer_manager.cc
@@ -45,8 +45,8 @@ ChildGpuMemoryBufferManager::AllocateGpuMemoryBuffer(const gfx::Size& size,
       content::GetNextGenericSharedMemoryId(), size.width(), size.height(),
       format, usage, &handle);
   bool success = sender_->Send(message);
-  if (!success || handle.is_null())
-    return nullptr;
+  CHECK(success);
+  CHECK(!handle.is_null());

[reveman, 2015/12/01 20:49:04]

It would be useful to know what arguments such as 'size' are when this fails.

Fyi, if CHECK(success) fails then we have the same problem in other manager
implementations. ChildDiscardableSharedMemoryManager, ChildSharedBitmapManager..

 
   scoped_ptr<GpuMemoryBufferImpl> buffer(GpuMemoryBufferImpl::CreateFromHandle(
       handle, size, format, usage,
@@ -54,8 +54,8 @@ ChildGpuMemoryBufferManager::AllocateGpuMemoryBuffer(const gfx::Size& size,
   if (!buffer) {

[reveman, 2015/12/01 20:49:04]

This doesn't make sense if we have a CHECK below. Maybe just
return GpuMemoryBufferImpl::CreateFromHandle(handle, size, ...)
here and have the caller CHECK the result?

     sender_->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(
         handle.id, gpu::SyncToken()));
-    return nullptr;
   }
+  CHECK(buffer);
 
   return buffer.Pass();
 }