Mac: Require child AllocateGpuMemoryBuffer to not fail

content/child/child_gpu_memory_buffer_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/child_gpu_memory_buffer_manager.h"
 
 #include "content/common/child_process_messages.h"
 #include "content/common/generic_shared_memory_id_generator.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
@@ skipping 27 matching lines @@
                "width",
                size.width(),
                "height",
                size.height());
 
   gfx::GpuMemoryBufferHandle handle;
   IPC::Message* message = new ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer(
       content::GetNextGenericSharedMemoryId(), size.width(), size.height(),
       format, usage, &handle);
   bool success = sender_->Send(message);
-  if (!success || handle.is_null())
-    return nullptr;
+  CHECK(success);
+  CHECK(!handle.is_null());

[reveman, 2015/12/01 20:49:04]

It would be useful to know what arguments such as 'size' are when this fails.

Fyi, if CHECK(success) fails then we have the same problem in other manager
implementations. ChildDiscardableSharedMemoryManager, ChildSharedBitmapManager..

 
   scoped_ptr<GpuMemoryBufferImpl> buffer(GpuMemoryBufferImpl::CreateFromHandle(
       handle, size, format, usage,
       base::Bind(&DeletedGpuMemoryBuffer, sender_, handle.id)));
   if (!buffer) {

[reveman, 2015/12/01 20:49:04]

This doesn't make sense if we have a CHECK below. Maybe just
return GpuMemoryBufferImpl::CreateFromHandle(handle, size, ...)
here and have the caller CHECK the result?

     sender_->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(
         handle.id, gpu::SyncToken()));
-    return nullptr;
   }
+  CHECK(buffer);
 
   return buffer.Pass();
 }
 
 scoped_ptr<gfx::GpuMemoryBuffer>
 ChildGpuMemoryBufferManager::CreateGpuMemoryBufferFromHandle(
     const gfx::GpuMemoryBufferHandle& handle,
     const gfx::Size& size,
     gfx::BufferFormat format) {
   NOTIMPLEMENTED();
   return nullptr;
 }
 
 gfx::GpuMemoryBuffer*
 ChildGpuMemoryBufferManager::GpuMemoryBufferFromClientBuffer(
     ClientBuffer buffer) {
   return GpuMemoryBufferImpl::FromClientBuffer(buffer);
 }
 
 void ChildGpuMemoryBufferManager::SetDestructionSyncToken(
     gfx::GpuMemoryBuffer* buffer,
     const gpu::SyncToken& sync_token) {
   static_cast<GpuMemoryBufferImpl*>(buffer)
       ->set_destruction_sync_token(sync_token);
 }
 
 }  // namespace content