Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1486863003:
mac: Sign app_mode_loader [badly] (Closed)
|
Created:
5 years ago by Mark Mentovai Modified:
5 years ago Reviewers:
Greg K CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmac: Sign app_mode_loader [badly]
Re-land of 2720613d5ea1, which was reverted in 51c465c92024.
We can't sign the app_mode_loader bundle because it's altered at runtime
as new app mode loader stubs are created. We can sign just the
executable. The resulting executable won't validate in its bundle
normally, and spctl won't like it, but it can be verified with
--ignore-resources, or in isolation from its bundle.
BUG=550972, 565859
Committed: https://crrev.com/b60f9895032816dede3c03921931d81c37a0adc4
Cr-Commit-Position: refs/heads/master@{#363208}
Patch Set 1 #Patch Set 2 : Re-land #Messages
Total messages: 17 (8 generated)
mark@chromium.org changed reviewers: + kerrnel@chromium.org
On 2015/12/01 15:19:39, Mark Mentovai wrote: LGTM
The CQ bit was checked by mark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486863003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== mac: Sign app_mode_loader [badly] We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972 ========== to ========== mac: Sign app_mode_loader [badly] We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972 Committed: https://crrev.com/2720613d5ea1db967ac883fcc9282ec60ad1ddd5 Cr-Commit-Position: refs/heads/master@{#363070} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2720613d5ea1db967ac883fcc9282ec60ad1ddd5 Cr-Commit-Position: refs/heads/master@{#363070}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1491213009/ by phajdan.jr@chromium.org. The reason for reverting is: Suspected for breaking official signing, see https://code.google.com/p/chromium/issues/detail?id=565859.
Message was sent while issue was closed.
Description was changed from ========== mac: Sign app_mode_loader [badly] We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972 Committed: https://crrev.com/2720613d5ea1db967ac883fcc9282ec60ad1ddd5 Cr-Commit-Position: refs/heads/master@{#363070} ========== to ========== mac: Sign app_mode_loader [badly] We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972 Committed: https://crrev.com/2720613d5ea1db967ac883fcc9282ec60ad1ddd5 Cr-Commit-Position: refs/heads/master@{#363070} ==========
Description was changed from ========== mac: Sign app_mode_loader [badly] We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972 Committed: https://crrev.com/2720613d5ea1db967ac883fcc9282ec60ad1ddd5 Cr-Commit-Position: refs/heads/master@{#363070} ========== to ========== mac: Sign app_mode_loader [badly] Re-land of 2720613d5ea1, which was reverted in 51c465c92024. We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972,565859 ==========
The CQ bit was checked by mark@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kerrnel@chromium.org Link to the patchset: https://codereview.chromium.org/1486863003/#ps20001 (title: "Re-land")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486863003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== mac: Sign app_mode_loader [badly] Re-land of 2720613d5ea1, which was reverted in 51c465c92024. We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972,565859 ========== to ========== mac: Sign app_mode_loader [badly] Re-land of 2720613d5ea1, which was reverted in 51c465c92024. We can't sign the app_mode_loader bundle because it's altered at runtime as new app mode loader stubs are created. We can sign just the executable. The resulting executable won't validate in its bundle normally, and spctl won't like it, but it can be verified with --ignore-resources, or in isolation from its bundle. BUG=550972,565859 Committed: https://crrev.com/b60f9895032816dede3c03921931d81c37a0adc4 Cr-Commit-Position: refs/heads/master@{#363208} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b60f9895032816dede3c03921931d81c37a0adc4 Cr-Commit-Position: refs/heads/master@{#363208} |
