Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1486843002: Sync the HTMLTableElement return types with the spec (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync the HTMLTableElement return types with the spec https://html.spec.whatwg.org/#the-table-element Changed in https://github.com/whatwg/html/pull/363 BUG=460722 Committed: https://crrev.com/808f8fa8eb87cdb554a3581bbb1186d708d4bf17 Cr-Commit-Position: refs/heads/master@{#362665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTableElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
philipj_slow
PTAL and CQ?
5 years ago (2015-12-01 19:35:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486843002/1
5 years ago (2015-12-01 19:37:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 21:39:05 UTC) #6
dominicc (has gone to gerrit)
lgtm
5 years ago (2015-12-02 08:10:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486843002/1
5 years ago (2015-12-02 08:10:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 08:58:06 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 08:58:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/808f8fa8eb87cdb554a3581bbb1186d708d4bf17
Cr-Commit-Position: refs/heads/master@{#362665}

Powered by Google App Engine
This is Rietveld 408576698