Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 1486843002: Sync the HTMLTableElement return types with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
index 088167c56f992f5afe8d0380648e4d8d9808df39..b03017e5f81b8a0e21ccefed992498a47df7c5a0 100644
--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
@@ -117,7 +117,7 @@ void HTMLTableElement::setTFoot(PassRefPtrWillBeRawPtr<HTMLTableSectionElement>
insertBefore(newFoot, child, exceptionState);
}
-PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableElement::createTHead()
+PassRefPtrWillBeRawPtr<HTMLTableSectionElement> HTMLTableElement::createTHead()
{
if (HTMLTableSectionElement* existingHead = tHead())
return existingHead;
@@ -131,7 +131,7 @@ void HTMLTableElement::deleteTHead()
removeChild(tHead(), IGNORE_EXCEPTION);
}
-PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableElement::createTFoot()
+PassRefPtrWillBeRawPtr<HTMLTableSectionElement> HTMLTableElement::createTFoot()
{
if (HTMLTableSectionElement* existingFoot = tFoot())
return existingFoot;
@@ -145,7 +145,7 @@ void HTMLTableElement::deleteTFoot()
removeChild(tFoot(), IGNORE_EXCEPTION);
}
-PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableElement::createTBody()
+PassRefPtrWillBeRawPtr<HTMLTableSectionElement> HTMLTableElement::createTBody()
{
RefPtrWillBeRawPtr<HTMLTableSectionElement> body = HTMLTableSectionElement::create(tbodyTag, document());
Node* referenceElement = lastBody() ? lastBody()->nextSibling() : 0;
@@ -154,7 +154,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableElement::createTBody()
return body.release();
}
-PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableElement::createCaption()
+PassRefPtrWillBeRawPtr<HTMLTableCaptionElement> HTMLTableElement::createCaption()
{
if (HTMLTableCaptionElement* existingCaption = caption())
return existingCaption;
@@ -173,7 +173,7 @@ HTMLTableSectionElement* HTMLTableElement::lastBody() const
return toHTMLTableSectionElement(Traversal<HTMLElement>::lastChild(*this, HasHTMLTagName(tbodyTag)));
}
-PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableElement::insertRow(int index, ExceptionState& exceptionState)
+PassRefPtrWillBeRawPtr<HTMLTableRowElement> HTMLTableElement::insertRow(int index, ExceptionState& exceptionState)
{
if (index < -1) {
exceptionState.throwDOMException(IndexSizeError, "The index provided (" + String::number(index) + ") is less than -1.");
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTableElement.h ('k') | third_party/WebKit/Source/core/html/HTMLTableElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698