Issue 1486753005: [Offline pages] Filter out offline pages without matching bookmarks in UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1486753005: [Offline pages] Filter out offline pages without matching bookmarks in UI (Closed)

Created:
5 years ago by fgorski

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

[Offline pages] Filter out offline pages without matching bookmarks in UI Making sure that when offline page filter is applied, all of the bookmark IDs are checked against the bookmark model, before being used by UI. BUG=537806 Review URL: https://codereview.chromium.org/1470403002 Cr-Commit-Position: refs/heads/master@{#362185} (cherry picked from commit f2d8e24f06b57fa0edc5dcd999516e3343d8a769) Committed: https://chromium.googlesource.com/chromium/src/+/2f936d9b8a1d2ab13d8b1a558d294b795e944e5a

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java	View		2 chunks	+10 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

fgorski

5 years ago (2015-12-01 22:45:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f936d9b8a1d2ab13d8b1a558d294b795e944e5a.