Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1939)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java

Issue 1486753005: [Offline pages] Filter out offline pages without matching bookmarks in UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
index 5ec67615c9b2ac7e8fb4b9819b0a1a5b9e58b82d..c0eea27e8c4fbc0bb0b974e6cb9e17d9d8caacc8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
@@ -27,6 +27,7 @@ import java.util.ArrayList;
import java.util.Calendar;
import java.util.Collections;
import java.util.Comparator;
+import java.util.HashSet;
import java.util.List;
import java.util.concurrent.TimeUnit;
@@ -327,9 +328,17 @@ public class EnhancedBookmarksModel extends BookmarksBridge {
List<OfflinePageItem> offlinePages = mOfflinePageBridge.getAllPages();
Collections.sort(offlinePages, sOfflinePageComparator);
+
+ // We are going to filter out all of the offline pages without a matching bookmark.
+ // http://crbug.com/537806
+ HashSet<BookmarkId> existingBookmarks =
+ new HashSet<BookmarkId>(getAllBookmarkIDsOrderedByCreationDate());
+
List<BookmarkId> bookmarkIds = new ArrayList<BookmarkId>();
for (OfflinePageItem offlinePage : offlinePages) {
- bookmarkIds.add(offlinePage.getBookmarkId());
+ if (existingBookmarks.contains(offlinePage.getBookmarkId())) {
+ bookmarkIds.add(offlinePage.getBookmarkId());
+ }
}
return bookmarkIds;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698