Removing test_server() and switching over to embedded_test_server.

Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672, 96594
Committed: https://crrev.com/799d159cc2fa62d2a69343e5cef8ebc3390f641d
Cr-Commit-Position: refs/heads/master@{#363057}

[svaldez, 2015-11-30 15:28:14]

svaldez@chromium.org changed reviewers:
+ eroman@chromium.org, thestig@chromium.org

[svaldez, 2015-11-30 15:28:15]

Mostly automated change over the remaining tests from using test_server() to
embedded_test_server().

[vabr (Chromium), 2015-11-30 15:43:31]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-11-30 15:43:31]

chrome/browser/ui/login/login_prompt_browsertest.cc LGTM

[eroman, 2015-11-30 19:27:03]

lgtm

[svaldez, 2015-11-30 20:04:04]

The CQ bit was checked by svaldez@chromium.org

[svaldez, 2015-11-30 20:04:04]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1486633002/#ps40001
(title: "More fixes.")

[svaldez, 2015-11-30 20:04:09]

The CQ bit was unchecked by svaldez@chromium.org

[davidben, 2015-11-30 20:29:48]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2015-11-30 20:29:48]

content/ lgtm

https://codereview.chromium.org/1486633002/diff/40001/content/public/test/bro...
File content/public/test/browser_test_base.h (left):

https://codereview.chromium.org/1486633002/diff/40001/content/public/test/bro...
content/public/test/browser_test_base.h:85: // TODO(phajdan.jr): Remove
test_server accessor (http://crbug.com/96594).
Might be worth stapling to this bug too.

[svaldez, 2015-11-30 20:33:42]

Description was changed from

==========
Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672
==========

to

==========
Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672,96594
==========

[svaldez, 2015-11-30 20:33:54]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2015-11-30 20:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486633002/40001

[commit-bot: I haz the power, 2015-11-30 20:58:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 20:58:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2015-12-01 13:33:25]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-12-01 13:33:25]

lgtm

https://codereview.chromium.org/1486633002/diff/40001/content/browser/resourc...
File content/browser/resource_loading_browsertest.cc (right):

https://codereview.chromium.org/1486633002/diff/40001/content/browser/resourc...
content/browser/resource_loading_browsertest.cc:5: #include <stdlib.h>
huh? ;)

[Lei Zhang, 2015-12-03 20:10:20]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-12-03 20:10:21]

lgtm

Post vacation stamp of approval.

[commit-bot: I haz the power, 2015-12-03 20:12:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486633002/40001

[commit-bot: I haz the power, 2015-12-03 21:10:15]

Description was changed from

==========
Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672,96594
==========

to

==========
Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672,96594
==========

[commit-bot: I haz the power, 2015-12-03 21:10:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-03 21:11:14]

Description was changed from

==========
Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672,96594
==========

to

==========
Removing test_server() and switching over to embedded_test_server.

This removes the last uses of test_server() and switches to using
embedded_test_server/spawned_test_server.

BUG=492672,96594

Committed: https://crrev.com/799d159cc2fa62d2a69343e5cef8ebc3390f641d
Cr-Commit-Position: refs/heads/master@{#363057}
==========

[commit-bot: I haz the power, 2015-12-03 21:11:14]

Patchset 3 (id:??) landed as
https://crrev.com/799d159cc2fa62d2a69343e5cef8ebc3390f641d
Cr-Commit-Position: refs/heads/master@{#363057}