Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 1486633002: Removing test_server() and switching over to embedded_test_server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_manager.h" 5 #include "components/translate/core/browser/translate_manager.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/prefs/session_startup_pref.h" 9 #include "chrome/browser/prefs/session_startup_pref.h"
10 #include "chrome/browser/translate/chrome_translate_client.h" 10 #include "chrome/browser/translate/chrome_translate_client.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 private: 54 private:
55 using LangageDetectionObserver = 55 using LangageDetectionObserver =
56 ui_test_utils::WindowedNotificationObserverWithDetails< 56 ui_test_utils::WindowedNotificationObserverWithDetails<
57 translate::LanguageDetectionDetails>; 57 translate::LanguageDetectionDetails>;
58 58
59 scoped_ptr<LangageDetectionObserver> language_detected_signal_; 59 scoped_ptr<LangageDetectionObserver> language_detected_signal_;
60 }; 60 };
61 61
62 // Tests that the CLD (Compact Language Detection) works properly. 62 // Tests that the CLD (Compact Language Detection) works properly.
63 IN_PROC_BROWSER_TEST_F(TranslateManagerBrowserTest, PageLanguageDetection) { 63 IN_PROC_BROWSER_TEST_F(TranslateManagerBrowserTest, PageLanguageDetection) {
64 ASSERT_TRUE(test_server()->Start()); 64 ASSERT_TRUE(embedded_test_server()->Start());
65 65
66 // The InProcessBrowserTest opens a new tab, let's wait for that first. 66 // The InProcessBrowserTest opens a new tab, let's wait for that first.
67 WaitUntilLanguageDetected(); 67 WaitUntilLanguageDetected();
68 68
69 content::WebContents* current_web_contents = 69 content::WebContents* current_web_contents =
70 browser()->tab_strip_model()->GetActiveWebContents(); 70 browser()->tab_strip_model()->GetActiveWebContents();
71 71
72 std::string adopted_language = GetLanguageFor(current_web_contents); 72 std::string adopted_language = GetLanguageFor(current_web_contents);
73 EXPECT_EQ("und", adopted_language); 73 EXPECT_EQ("und", adopted_language);
74 74
75 // Open a new tab with a page in English. 75 // Open a new tab with a page in English.
76 AddTabAtIndex(0, GURL(test_server()->GetURL("files/english_page.html")), 76 AddTabAtIndex(0, GURL(embedded_test_server()->GetURL("/english_page.html")),
77 ui::PAGE_TRANSITION_TYPED); 77 ui::PAGE_TRANSITION_TYPED);
78 78
79 ResetObserver(); 79 ResetObserver();
80 80
81 current_web_contents = browser()->tab_strip_model()->GetActiveWebContents(); 81 current_web_contents = browser()->tab_strip_model()->GetActiveWebContents();
82 ChromeTranslateClient* chrome_translate_client = 82 ChromeTranslateClient* chrome_translate_client =
83 ChromeTranslateClient::FromWebContents(current_web_contents); 83 ChromeTranslateClient::FromWebContents(current_web_contents);
84 84
85 WaitUntilLanguageDetected(); 85 WaitUntilLanguageDetected();
86 adopted_language = GetLanguageFor(current_web_contents); 86 adopted_language = GetLanguageFor(current_web_contents);
87 EXPECT_EQ("en", adopted_language); 87 EXPECT_EQ("en", adopted_language);
88 EXPECT_EQ("en", 88 EXPECT_EQ("en",
89 chrome_translate_client->GetLanguageState().original_language()); 89 chrome_translate_client->GetLanguageState().original_language());
90 90
91 ResetObserver(); 91 ResetObserver();
92 92
93 // Now navigate to a page in French. 93 // Now navigate to a page in French.
94 ui_test_utils::NavigateToURL( 94 ui_test_utils::NavigateToURL(
95 browser(), GURL(test_server()->GetURL("files/french_page.html"))); 95 browser(), GURL(embedded_test_server()->GetURL("/french_page.html")));
96 96
97 WaitUntilLanguageDetected(); 97 WaitUntilLanguageDetected();
98 adopted_language = GetLanguageFor(current_web_contents); 98 adopted_language = GetLanguageFor(current_web_contents);
99 EXPECT_EQ("fr", adopted_language); 99 EXPECT_EQ("fr", adopted_language);
100 EXPECT_EQ("fr", 100 EXPECT_EQ("fr",
101 chrome_translate_client->GetLanguageState().original_language()); 101 chrome_translate_client->GetLanguageState().original_language());
102 } 102 }
103 103
104 // Test is flaky on Win http://crbug.com/166334 104 // Test is flaky on Win http://crbug.com/166334
105 #if defined(OS_WIN) 105 #if defined(OS_WIN)
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 active_adopted_language = GetLanguageFor(active_web_contents); 162 active_adopted_language = GetLanguageFor(active_web_contents);
163 } else if (restored_adopted_language.empty()) { 163 } else if (restored_adopted_language.empty()) {
164 ResetObserver(); 164 ResetObserver();
165 WaitUntilLanguageDetected(); 165 WaitUntilLanguageDetected();
166 restored_adopted_language = GetLanguageFor(restored_web_contents); 166 restored_adopted_language = GetLanguageFor(restored_web_contents);
167 } 167 }
168 168
169 EXPECT_EQ("fr", restored_adopted_language); 169 EXPECT_EQ("fr", restored_adopted_language);
170 EXPECT_EQ("und", active_adopted_language); 170 EXPECT_EQ("und", active_adopted_language);
171 } 171 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698