xfa/include/fxfa/fxfa_widget.h - Issue 1486573002: Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/include/fxfa/fxfa_widget.h

Issue 1486573002: Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/include/fxfa/fxfa_widget.h

diff --git a/xfa/include/fxfa/fxfa_widget.h b/xfa/include/fxfa/fxfa_widget.h

index 634a28762817d4d28a12d92570545a20c02f9669..9d67177777d492573de789cc6b72edc77626f87d 100644

--- a/xfa/include/fxfa/fxfa_widget.h

+++ b/xfa/include/fxfa/fxfa_widget.h

@@ -113,5 +113,6 @@ class CXFA_WidgetAcc : public CXFA_WidgetData {

void StartTextLayout(FX_FLOAT& fCalcWidth, FX_FLOAT& fCalcHeight);

CXFA_FFDocView* m_pDocView;

CXFA_WidgetLayoutData* m_pLayoutData;

+ uint32_t m_nRecurRef;

Tom Sepez 2015/11/30 17:22:09 nit: Can we call this m_nRecursionDepth ? Althoug

jun_fang 2015/12/01 04:24:39 Acknowledged.

};

#endif

« no previous file with comments | « no previous file | xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp » ('j') | xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp » ('J')