xfa/include/fxfa/fxfa_widget.h - Issue 1486573002: Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/include/fxfa/fxfa_widget.h

Issue 1486573002: Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef _FXFA_WIDGET_H	7 #ifndef _FXFA_WIDGET_H

8 #define _FXFA_WIDGET_H	8 #define _FXFA_WIDGET_H

9 class CXFA_Node;	9 class CXFA_Node;

10 class CXFA_FFDocView;	10 class CXFA_FFDocView;

(...skipping 95 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
106 FX_FLOAT GetWidthWithoutMargin(FX_FLOAT fWidthCalc);	106 FX_FLOAT GetWidthWithoutMargin(FX_FLOAT fWidthCalc);

107 FX_FLOAT GetHeightWithoutMargin(FX_FLOAT fHeightCalc);	107 FX_FLOAT GetHeightWithoutMargin(FX_FLOAT fHeightCalc);

108 void CalculateTextContentSize(CFX_SizeF& size);	108 void CalculateTextContentSize(CFX_SizeF& size);

109 void CalculateAccWidthAndHeight(XFA_ELEMENT eUIType,	109 void CalculateAccWidthAndHeight(XFA_ELEMENT eUIType,

110 FX_FLOAT& fWidth,	110 FX_FLOAT& fWidth,

111 FX_FLOAT& fCalcHeight);	111 FX_FLOAT& fCalcHeight);

112 void InitLayoutData();	112 void InitLayoutData();

113 void StartTextLayout(FX_FLOAT& fCalcWidth, FX_FLOAT& fCalcHeight);	113 void StartTextLayout(FX_FLOAT& fCalcWidth, FX_FLOAT& fCalcHeight);

114 CXFA_FFDocView* m_pDocView;	114 CXFA_FFDocView* m_pDocView;

115 CXFA_WidgetLayoutData* m_pLayoutData;	115 CXFA_WidgetLayoutData* m_pLayoutData;

	116 uint32_t m_nRecurRef;
	Tom Sepez 2015/11/30 17:22:09 nit: Can we call this m_nRecursionDepth ? Althoug nit: Can we call this m_nRecursionDepth ? Although similar to ref counting, folks usually talk about the "Depth of the recursion" and this might make more sense to the readers. jun_fang 2015/12/01 04:24:39 Acknowledged. Show quoted text On 2015/11/30 17:22:09, Tom Sepez wrote: > nit: Can we call this m_nRecursionDepth ? Although similar to ref counting, > folks usually talk about the "Depth of the recursion" and this might make more > sense to the readers. Acknowledged.
116 };	117 };

117 #endif	118 #endif

OLD	NEW

« no previous file with comments | « no previous file | xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp » ('j') | xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp » ('J')