Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486573002: Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript() (Closed)

Created:
5 years ago by jun_fang
Modified:
5 years ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript() BUG=pdfium:292 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0e4e36878682e22678bb061e77d73f3a4581985c

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M xfa/include/fxfa/fxfa_widget.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jun_fang
Hi Tom and Lei, Please review this CL. Thanks! https://codereview.chromium.org/1486573002/diff/1/xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp File xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp (right): https://codereview.chromium.org/1486573002/diff/1/xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp#newcode636 xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp:636: ...
5 years ago (2015-11-30 09:19:31 UTC) #2
Tom Sepez
LGTM with nit. https://codereview.chromium.org/1486573002/diff/1/xfa/include/fxfa/fxfa_widget.h File xfa/include/fxfa/fxfa_widget.h (right): https://codereview.chromium.org/1486573002/diff/1/xfa/include/fxfa/fxfa_widget.h#newcode116 xfa/include/fxfa/fxfa_widget.h:116: uint32_t m_nRecurRef; nit: Can we call ...
5 years ago (2015-11-30 17:22:10 UTC) #3
jun_fang
Committed patchset #2 (id:20001) manually as 0e4e36878682e22678bb061e77d73f3a4581985c (presubmit successful).
5 years ago (2015-12-01 04:23:52 UTC) #5
jun_fang
5 years ago (2015-12-01 04:24:39 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1486573002/diff/1/xfa/include/fxfa/fxfa_widget.h
File xfa/include/fxfa/fxfa_widget.h (right):

https://codereview.chromium.org/1486573002/diff/1/xfa/include/fxfa/fxfa_widge...
xfa/include/fxfa/fxfa_widget.h:116: uint32_t m_nRecurRef;
On 2015/11/30 17:22:09, Tom Sepez wrote:
> nit: Can we call this m_nRecursionDepth ?  Although similar to ref counting,
> folks usually talk about the "Depth of the recursion" and this might make more
> sense to the readers.

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698