tool/build_sdk.sh - Issue 1486473002: Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/build_sdk.sh

Issue 1486473002: Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tool/build_sdk.sh

diff --git a/tool/build_sdk.sh b/tool/build_sdk.sh

index 8a30ea5417db5ad165c2484b5db46e45477cdbe2..e1e899004993d407691e31b32114bef7306ed39b 100755

--- a/tool/build_sdk.sh

+++ b/tool/build_sdk.sh

@@ -11,5 +11,6 @@ echo "*** Compiling SDK to JavaScript"

dart -c bin/dartdevc.dart --no-source-maps --arrow-fn-bind-this --sdk-check \

--force-compile -l warning --dart-sdk tool/generated_sdk -o lib/runtime/ \

"$@" \

+ dart:_utils \

Jennifer Messerly 2015/11/30 18:54:11 hmmm, one idea here is: if this is imported by oth

ochafik 2015/12/01 14:41:03 Ha! Added a phony import in js_primitives.dart + t

dart:js dart:mirrors \

> tool/sdk_expected_errors.txt || true

« lib/src/codegen/js_codegen.dart ('K') | « test/codegen/expect/unittest/unittest.js ('k') | tool/input_sdk/lib/_internal/libraries.dart » ('j') | tool/input_sdk/private/utils.dart » ('J')