tool/build_sdk.sh - Issue 1486473002: Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tool/build_sdk.sh

Issue 1486473002: Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 set -e	2 set -e

3 # switch to the root directory of dev_compiler	3 # switch to the root directory of dev_compiler

4 cd $( dirname "${BASH_SOURCE[0]}" )/..	4 cd $( dirname "${BASH_SOURCE[0]}" )/..

5	5

6 echo "*** Patching SDK"	6 echo "*** Patching SDK"

7 dart -c tool/patch_sdk.dart tool/input_sdk tool/generated_sdk	7 dart -c tool/patch_sdk.dart tool/input_sdk tool/generated_sdk

8	8

9 echo "*** Compiling SDK to JavaScript"	9 echo "*** Compiling SDK to JavaScript"

10	10

11 dart -c bin/dartdevc.dart --no-source-maps --arrow-fn-bind-this --sdk-check \	11 dart -c bin/dartdevc.dart --no-source-maps --arrow-fn-bind-this --sdk-check \

12 --force-compile -l warning --dart-sdk tool/generated_sdk -o lib/runtime/ \	12 --force-compile -l warning --dart-sdk tool/generated_sdk -o lib/runtime/ \

13 "$@" \	13 "$@" \

	14 dart:_utils \
	Jennifer Messerly 2015/11/30 18:54:11 hmmm, one idea here is: if this is imported by oth hmmm, one idea here is: if this is imported by other libraries, in which case it should be picked up automatically. Is that working for you? ochafik 2015/12/01 14:41:03 Ha! Added a phony import in js_primitives.dart + t Show quoted text On 2015/11/30 18:54:11, John Messerly wrote: > hmmm, one idea here is: if this is imported by other libraries, in which case it > should be picked up automatically. Is that working for you? Ha! Added a phony import in js_primitives.dart + todo.
14 dart:js dart:mirrors \	15 dart:js dart:mirrors \

15 > tool/sdk_expected_errors.txt \|\| true	16 > tool/sdk_expected_errors.txt \|\| true

OLD	NEW

« lib/src/codegen/js_codegen.dart ('K') | « test/codegen/expect/unittest/unittest.js ('k') | tool/input_sdk/lib/_internal/libraries.dart » ('j') | tool/input_sdk/private/utils.dart » ('J')