Mojo-ifying chrome://version.

chrome/browser/extensions/active_tab_unittest.cc

Index: chrome/browser/extensions/active_tab_unittest.cc
diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc
index be5668c04ca734c66eb5d8ad796f671aed8e0441..1a83bca3a7da778336a57a528e9de4cfc96dcaf1 100644
--- a/chrome/browser/extensions/active_tab_unittest.cc
+++ b/chrome/browser/extensions/active_tab_unittest.cc
@@ -361,7 +361,7 @@ TEST_F(ActiveTabTest, NavigateInPage) {
 }
 
 TEST_F(ActiveTabTest, ChromeUrlGrants) {
-  GURL internal("chrome://version");
+  GURL internal("chrome://about");

[Dan Beam, 2015/12/09 21:45:07]

why is this necessary?

[dpapad, 2015/12/10 01:08:27]

This is already explained previously in this review. Repeating here:

@devlin.cronin already reviewed this part. The context for this change is that
instantiating a MojoWebUIController in the context of a unit_test fails. For
this particular test the exact chrome URL does not matter so changing to
chrome://about is sufficient. Eventually I will file a bug on the Mojo side to
provide a solution on how to handle such cases in the future.

   NavigateAndCommit(internal);
   active_tab_permission_granter()->GrantIfRequested(
       extension_with_tab_capture.get());