Mojo-ifying chrome://version.

chrome/browser/extensions/active_tab_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/values.h"
@@ skipping 343 matching lines @@
 
   Reload();
 
   EXPECT_FALSE(IsAllowed(extension, google));
   EXPECT_FALSE(IsAllowed(extension, google_h1));
   EXPECT_FALSE(IsAllowed(extension, chromium));
   EXPECT_FALSE(IsAllowed(extension, chromium_h1));
 }
 
 TEST_F(ActiveTabTest, ChromeUrlGrants) {
-  GURL internal("chrome://version");
+  GURL internal("chrome://about");

[Dan Beam, 2015/12/09 21:45:07]

why is this necessary?

[dpapad, 2015/12/10 01:08:27]

This is already explained previously in this review. Repeating here:

@devlin.cronin already reviewed this part. The context for this change is that
instantiating a MojoWebUIController in the context of a unit_test fails. For
this particular test the exact chrome URL does not matter so changing to
chrome://about is sufficient. Eventually I will file a bug on the Mojo side to
provide a solution on how to handle such cases in the future.

   NavigateAndCommit(internal);
   active_tab_permission_granter()->GrantIfRequested(
       extension_with_tab_capture.get());
   // Do not grant tabs/hosts permissions for tab.
   EXPECT_TRUE(IsAllowed(extension_with_tab_capture, internal,
                         PERMITTED_CAPTURE_ONLY));
   const PermissionsData* permissions_data =
       extension_with_tab_capture->permissions_data();
   EXPECT_TRUE(permissions_data->HasAPIPermissionForTab(
       tab_id(), APIPermission::kTabCaptureForTab));
 
   EXPECT_TRUE(IsBlocked(extension_with_tab_capture, internal, tab_id() + 1));
   EXPECT_FALSE(permissions_data->HasAPIPermissionForTab(
       tab_id() + 1, APIPermission::kTabCaptureForTab));
 }
 
 }  // namespace
 }  // namespace extensions