Chromium Code Reviews
Description[Merge M48] mac: Fix unit test crash.
> The test OmniboxPopupViewMacTest was crashing because of an invalid pointer
> dereference. The root cause was that a base::scoped_nsobject member was captured
> as an implicit parameter to an Obj-C block, which makes a raw copy of the |this|
> pointer. I changed the captured parameter to be an Obj-C object, which
> automatically gets retained/released.
>
> BUG=551007, 560482
>
> Review URL: https://codereview.chromium.org/1466333004
>
> Cr-Commit-Position: refs/heads/master@{#362184}
(cherry picked from commit 36c234e5d9647c2cf891ddcd574ea0078162ca79)
TBR=mark@chromium.org
BUG=560482
Committed: https://chromium.googlesource.com/chromium/src/+/08d0a8756efac1f5dc18ec62e7cb3e1f6fcec55f
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||