Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1486393002: [Merge M48] mac: Fix unit test crash. (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Merge M48] mac: Fix unit test crash. > The test OmniboxPopupViewMacTest was crashing because of an invalid pointer > dereference. The root cause was that a base::scoped_nsobject member was captured > as an implicit parameter to an Obj-C block, which makes a raw copy of the |this| > pointer. I changed the captured parameter to be an Obj-C object, which > automatically gets retained/released. > > BUG=551007, 560482 > > Review URL: https://codereview.chromium.org/1466333004 > > Cr-Commit-Position: refs/heads/master@{#362184} (cherry picked from commit 36c234e5d9647c2cf891ddcd574ea0078162ca79) TBR=mark@chromium.org BUG=560482 Committed: https://chromium.googlesource.com/chromium/src/+/08d0a8756efac1f5dc18ec62e7cb3e1f6fcec55f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
erikchen
Committed patchset #1 (id:1) manually as 08d0a8756efac1f5dc18ec62e7cb3e1f6fcec55f (presubmit successful).
5 years ago (2015-12-02 01:52:20 UTC) #2
Mark Mentovai
5 years ago (2015-12-02 03:10:56 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698