mac: Fix unit test crash.

mac: Fix unit test crash.

The test OmniboxPopupViewMacTest was crashing because of an invalid pointer
dereference. The root cause was that a base::scoped_nsobject member was captured
as an implicit parameter to an Obj-C block, which makes a raw copy of the |this|
pointer. I changed the captured parameter to be an Obj-C object, which
automatically gets retained/released.

BUG=551007, 560482
Committed: https://crrev.com/36c234e5d9647c2cf891ddcd574ea0078162ca79
Cr-Commit-Position: refs/heads/master@{#362184}

[erikchen, 2015-11-23 23:38:19]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2015-11-23 23:38:19]

mark: Please review.

[erikchen, 2015-11-30 18:27:04]

On 2015/11/23 23:38:19, erikchen wrote:
> mark: Please review.

mark: Ping?

[Mark Mentovai, 2015-11-30 18:33:59]

LGTM

https://codereview.chromium.org/1466333004/diff/1/chrome/browser/ui/cocoa/omn...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1466333004/diff/1/chrome/browser/ui/cocoa/omn...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:287: NSWindow* popup =
popup_.get();
Aha, tricky!

[erikchen, 2015-11-30 18:34:24]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-11-30 18:37:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466333004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466333004/1

[commit-bot: I haz the power, 2015-11-30 19:13:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-30 19:14:59]

Description was changed from

==========
mac: Fix unit test crash.

The test OmniboxPopupViewMacTest was crashing because of an invalid pointer
dereference. The root cause was that a base::scoped_nsobject member was captured
as an implicit parameter to an Obj-C block, which makes a raw copy of the |this|
pointer. I changed the captured parameter to be an Obj-C object, which
automatically gets retained/released.

BUG=551007, 560482
==========

to

==========
mac: Fix unit test crash.

The test OmniboxPopupViewMacTest was crashing because of an invalid pointer
dereference. The root cause was that a base::scoped_nsobject member was captured
as an implicit parameter to an Obj-C block, which makes a raw copy of the |this|
pointer. I changed the captured parameter to be an Obj-C object, which
automatically gets retained/released.

BUG=551007, 560482

Committed: https://crrev.com/36c234e5d9647c2cf891ddcd574ea0078162ca79
Cr-Commit-Position: refs/heads/master@{#362184}
==========

[commit-bot: I haz the power, 2015-11-30 19:15:00]

Patchset 1 (id:??) landed as
https://crrev.com/36c234e5d9647c2cf891ddcd574ea0078162ca79
Cr-Commit-Position: refs/heads/master@{#362184}