Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1486323002: Remove plumbing of clipRect in GrAtlasTextContext (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove plumbing of clipRect thoughout the TextContexts The RenderTarget was only being passed around to be able to recreate the clipRect. Committed: https://skia.googlesource.com/skia/+/6ee690e1d838e152c134257bdd57e9a1509ee7c2

Patch Set 1 #

Patch Set 2 : Remove RenderTarget parameter too #

Patch Set 3 : Missed one #

Patch Set 4 : Remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -124 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 2 6 chunks +21 lines, -23 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 34 chunks +39 lines, -93 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
robertphillips
5 years ago (2015-12-01 22:56:44 UTC) #3
robertphillips
5 years ago (2015-12-02 13:51:09 UTC) #5
joshualitt
On 2015/12/02 13:51:09, robertphillips wrote: lgtm
5 years ago (2015-12-02 14:50:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486323002/60001
5 years ago (2015-12-02 16:40:19 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 16:53:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486323002/60001
5 years ago (2015-12-02 16:57:15 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-02 16:57:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6ee690e1d838e152c134257bdd57e9a1509ee7c2

Powered by Google App Engine
This is Rietveld 408576698